Skip to content

Core #1199: resume verified dependency waits and bound activity wakes - #1341

Merged
oxa-orchestrator[bot] merged 9 commits into
mainfrom
agent/1199-dependency-resume
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 9 commits into
mainfrom
agent/1199-dependency-resume

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Implements the next Core data/rules slice of #1199 and the #307 native Board/feeder row: a worker parked on a verified dependency can take its next eligible item, then resume the original attempt only after fresh clearance and an atomic worker-idle check.

T3. Reuses the existing Claims row, private atomic writer and directory lock. resume_dependency_for checks the original full host-bound lease, latest renewable expiry, immutable NativeBinding, exact stored dependency and current assignment revision. Other unfinished running work, including expired leases, and imported holds block resume. Deadlines never release work, refund attempts or grant clearance. Optional owner-selected ActivityTiming validates intervals and computes bounded future wakes without an overdue spin loop. Lead owns runtime signal/wake/recovery fences; Work2 owns real CLI conformance.

Own delta:322 lines (314 additions +8 deletions), six Rust files. Actual conflicts with landed #1327 were resolved by normal main merge; main's check_recovery export and all resume tests are preserved. The own patch ID is unchanged. No configuration activation, additional store or authority.

Validation for current head 37ff9e2387fd629dc936d546d5cea62c21c3c381:

  • Selected CI44258806537: SUCCESS on this exact head; oxa-cli, oxa-parity and oxa-work selected. Both x86 and ARM passed1,626 tests each with zero skips, plus doctests. Original observer completed successfully.
  • Ready required CI44259025622: SUCCESS on this exact head, including clippy, real binary build, mandatory-bwrap archive/partitions and test-inventory gate:4,981 expected tests passed once, zero runtime skips. Original observer completed successfully.
  • Owner07:27Z read and approved this exact source in the existing packet.
  • Connected current-head Code6972158105 and Security6972182330 explicitly reviewed37ff9e2387 and are clean.
  • Local oxa-work formatting and diff checks pass. Whole-workspace local formatting reports an inherited oxa-proto macro layout; no unrelated source edits. All compiler and test work runs in CI.

Behavior controls exercise actual next-item admission while parked, original receipt/binding/attempt preservation, busy/false/stale/wrong-wait refusal, simultaneous clears allowing only one running item, import holds, bounded wake and arithmetic overflow. Previous composition22fd selected CI44255276174 passed1,618 tests per x86/ARM with zero skips; that is historical evidence, not current-head qualification. Normal current CI, clean connected reviews and integrated merge queue remain required.

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T07:33:27.964821Z 37ff9e2 Manual request
🔒 Security Review ✅ Completed 2026-11-18T07:34:43.065700Z 37ff9e2 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 37ff9e2387

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 37ff9e2387

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator

Copy link
Copy Markdown

st merge-flow>author #134137ff9e2 queue=REJECTED run=? next=refresh-on-main note="Composition with current main failed; rebase/merge main, fix, push; a new head needs a new verdict."

see run log

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 61623cb Nov 18, 2026
52 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1199-dependency-resume branch November 18, 2026 07:48
@oxa-agent

oxa-agent Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

#1341 is MERGED at 61623cb3d1c97259111ff0185a2cbbae8801904a (2026-11-18 07:48:41 UTC). Exact queue run44260351911 succeeded on the same integrated tree. All six owned Core files are byte-identical to reviewed37ff9e23.

Current-source qualification: selected44258806537 succeeded with1,626 passing tests on each x86/ARM, zero skips and doctests; Ready required44259025622 succeeded with4,981 expected workspace tests executed once, zero runtime skips. Owner07:27 exact-source read resolved; Code6972158105 and Security6972182330 explicitly reviewed37ff and are clean; no unresolved review threads. Original CI observers completed successfully.

Available in oxa_work::board: Claims::resume_dependency_for(worker,host,&NativeBinding,&ItemLease,now,expected_revision,&DependencyWait,verifyFreshClear)->Result; ActivityTiming { heartbeat_interval_secs, silence_secs }, validate and next_wake. Same Claims lock/row, original full receipt/renewed expiry/binding, exact wait and revision; fresh clearance plus no other unparked worker work. Imported holds and expired unfinished work remain fences. No deadline-based clearance, attempt refund, lease replacement or additional store.

Lead owns both native_queue runnable selection and Consumer::once hosted preflight. Work2 retains producer/isolated CLI and has handed the exact shared hunk to Lead. Runtime productive-next/all-parked acceptance remains separate and unqualified by this Core landing. No activation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant